From 380dff555f3fe022a779bed3c76f8f0012332a7e Mon Sep 17 00:00:00 2001 From: mxb Date: Mon, 25 Feb 2019 12:05:30 +0100 Subject: [PATCH 1/5] Replaced makeSingleInstance method, deprecated --- electron/main.js | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/electron/main.js b/electron/main.js index d7e2ba74..dfbb78e9 100644 --- a/electron/main.js +++ b/electron/main.js @@ -312,21 +312,22 @@ ipcMain.on('relaunchApp', function(event) { app.exit(0); }); -const shouldQuit = app.makeSingleInstance((commandLine, workingDirectory) => { - // Someone tried to run a second instance, we should focus our window. - if (mainWindow) { - if (mainWindow.isMinimized()) mainWindow.restore(); - mainWindow.focus(); - mainWindow.show(); - mainWindow.setSkipTaskbar(false); - if (app.dock && app.dock.show) app.dock.show(); - } -}); - -if (shouldQuit) { +const shouldQuit = app.requestSingleInstanceLock() +if (!shouldQuit) { app.quit(); return; } +app.on('second-instance', (event, commandLine, workingDirectory) => { + // Someone tried to run a second instance, we should focus our window. + if (mainWindow) { + if (mainWindow.isMinimized()) mainWindow.restore(); + mainWindow.focus(); + mainWindow.show(); + mainWindow.setSkipTaskbar(false); + if (app.dock && app.dock.show) app.dock.show(); + } +}); + // Code for downloading images as temporal files // Credit: Ghetto Skype (https://github.com/stanfieldr/ghetto-skype) From 5941ba18aed22c0d7c6f254c70aae3d879bbc2b3 Mon Sep 17 00:00:00 2001 From: mxb Date: Mon, 25 Feb 2019 12:05:51 +0100 Subject: [PATCH 2/5] did-get-redirect-request events removed --- app/ux/Auth0.js | 4 ++-- app/ux/WebView.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/ux/Auth0.js b/app/ux/Auth0.js index 7e420e08..7b928944 100644 --- a/app/ux/Auth0.js +++ b/app/ux/Auth0.js @@ -270,8 +270,8 @@ Ext.define('Rambox.ux.Auth0', { authWindow.loadURL(me.authService.requestAuthCode()); - authWindow.webContents.on('did-get-redirect-request', function(e, oldUrl, newUrl) { - me.authService.requestAccessCode(newUrl, me.onLogin.bind(me), authWindow); + authWindow.webContents.on('did-navigate', function(e, url) { + me.authService.requestAccessCode(url, me.onLogin.bind(me), authWindow); }); } diff --git a/app/ux/WebView.js b/app/ux/WebView.js index ba649dcd..adeb9d13 100644 --- a/app/ux/WebView.js +++ b/app/ux/WebView.js @@ -514,7 +514,7 @@ Ext.define('Rambox.ux.WebView',{ }); } - webview.addEventListener('did-get-redirect-request', function( e ) { + webview.addEventListener('did-navigate', function( e ) { if ( e.isMainFrame && me.record.get('type') === 'tweetdeck' ) Ext.defer(function() { webview.loadURL(e.newURL); }, 1000); // Applied a defer because sometimes is not redirecting. TweetDeck 2FA is an example. }); From 382c382bca080e5a226950f90b60c14c60fdd4dd Mon Sep 17 00:00:00 2001 From: mxb Date: Mon, 25 Feb 2019 12:07:21 +0100 Subject: [PATCH 3/5] Updated electron version --- package-lock.json | 103 +++++++++++++++++++++------------------------- package.json | 2 +- 2 files changed, 48 insertions(+), 57 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9f3ce0f7..8a7d1254 100644 --- a/package-lock.json +++ b/package-lock.json @@ -44,9 +44,9 @@ } }, "@types/node": { - "version": "8.10.38", - "resolved": "https://registry.npmjs.org/@types/node/-/node-8.10.38.tgz", - "integrity": "sha512-EibsnbJerd0hBFaDjJStFrVbVBAtOy4dgL8zZFw0uOvPqzBAX59Ci8cgjg3+RgJIWhsB5A4c+pi+D4P9tQQh/A==", + "version": "8.10.40", + "resolved": "https://registry.npmjs.org/@types/node/-/node-8.10.40.tgz", + "integrity": "sha512-RRSjdwz63kS4u7edIwJUn8NqKLLQ6LyqF/X4+4jp38MBT3Vwetewi2N4dgJEshLbDwNgOJXNYoOwzVZUSSLhkQ==", "dev": true }, "abbrev": { @@ -1712,13 +1712,13 @@ "dev": true }, "electron": { - "version": "2.0.14", - "resolved": "https://registry.npmjs.org/electron/-/electron-2.0.14.tgz", - "integrity": "sha512-8HLVZuscZxVhoMUL6RlF5kMcwGUAMWw5HNwrEmRgzZyBIBbdCO4aMo9z0qknnPTUDROz8xXZFNhFvBXDu61g5Q==", + "version": "3.1.4", + "resolved": "https://registry.npmjs.org/electron/-/electron-3.1.4.tgz", + "integrity": "sha512-YJEvfq45K7MmhLXY4mpGLG/cH5BU/1NUOcNMRzLxs3wVS/fKY2ZkJrOTncxhi1VOC1EJOQslcSdupitrW/FSig==", "dev": true, "requires": { "@types/node": "^8.0.24", - "electron-download": "^3.0.1", + "electron-download": "^4.1.0", "extract-zip": "^1.0.3" } }, @@ -1815,59 +1815,62 @@ } }, "electron-download": { - "version": "3.3.0", - "resolved": "https://registry.npmjs.org/electron-download/-/electron-download-3.3.0.tgz", - "integrity": "sha1-LP1U1pZsAZxNSa1l++Zcyc3vaMg=", + "version": "4.1.1", + "resolved": "https://registry.npmjs.org/electron-download/-/electron-download-4.1.1.tgz", + "integrity": "sha512-FjEWG9Jb/ppK/2zToP+U5dds114fM1ZOJqMAR4aXXL5CvyPE9fiqBK/9YcwC9poIFQTEJk/EM/zyRwziziRZrg==", "dev": true, "requires": { - "debug": "^2.2.0", - "fs-extra": "^0.30.0", - "home-path": "^1.0.1", + "debug": "^3.0.0", + "env-paths": "^1.0.0", + "fs-extra": "^4.0.1", "minimist": "^1.2.0", - "nugget": "^2.0.0", - "path-exists": "^2.1.0", - "rc": "^1.1.2", - "semver": "^5.3.0", - "sumchecker": "^1.2.0" + "nugget": "^2.0.1", + "path-exists": "^3.0.0", + "rc": "^1.2.1", + "semver": "^5.4.1", + "sumchecker": "^2.0.2" }, "dependencies": { - "fs-extra": { - "version": "0.30.0", - "resolved": "http://registry.npmjs.org/fs-extra/-/fs-extra-0.30.0.tgz", - "integrity": "sha1-8jP/zAjU2n1DLapEl3aYnbHfk/A=", + "debug": { + "version": "3.2.6", + "resolved": "https://registry.npmjs.org/debug/-/debug-3.2.6.tgz", + "integrity": "sha512-mel+jf7nrtEl5Pn1Qx46zARXKDpBbvzezse7p7LqINmdoIk8PYP5SySaxEmYv6TZ0JyEKA1hsCId6DIhgITtWQ==", "dev": true, "requires": { - "graceful-fs": "^4.1.2", - "jsonfile": "^2.1.0", - "klaw": "^1.0.0", - "path-is-absolute": "^1.0.0", - "rimraf": "^2.2.8" + "ms": "^2.1.1" } }, - "minimist": { - "version": "1.2.0", - "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", - "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", - "dev": true - }, - "path-exists": { - "version": "2.1.0", - "resolved": "https://registry.npmjs.org/path-exists/-/path-exists-2.1.0.tgz", - "integrity": "sha1-D+tsZPD8UY2adU3V77YscCJ2H0s=", + "fs-extra": { + "version": "4.0.3", + "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-4.0.3.tgz", + "integrity": "sha512-q6rbdDd1o2mAnQreO7YADIxf/Whx4AHBiRf6d+/cVT8h44ss+lHgxf1FemcqDnQt9X3ct4McHr+JMGlYSsK7Cg==", "dev": true, "requires": { - "pinkie-promise": "^2.0.0" + "graceful-fs": "^4.1.2", + "jsonfile": "^4.0.0", + "universalify": "^0.1.0" } }, - "sumchecker": { - "version": "1.3.1", - "resolved": "https://registry.npmjs.org/sumchecker/-/sumchecker-1.3.1.tgz", - "integrity": "sha1-ebs7RFbdBPGOvbwNcDodHa7FEF0=", + "jsonfile": { + "version": "4.0.0", + "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-4.0.0.tgz", + "integrity": "sha1-h3Gq4HmbZAdrdmQPygWPnBDjPss=", "dev": true, "requires": { - "debug": "^2.2.0", - "es6-promise": "^4.0.5" + "graceful-fs": "^4.1.6" } + }, + "minimist": { + "version": "1.2.0", + "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", + "dev": true + }, + "ms": { + "version": "2.1.1", + "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.1.tgz", + "integrity": "sha512-tgp+dl5cGk28utYktBsrFqA7HKgrhgPsg6Z/EfhWI4gl1Hwq8B/GmY/0oXZ6nF8hDVesS/FpnYaD/kOWhYQvyg==", + "dev": true } } }, @@ -2133,12 +2136,6 @@ "is-arrayish": "^0.2.1" } }, - "es6-promise": { - "version": "4.2.5", - "resolved": "https://registry.npmjs.org/es6-promise/-/es6-promise-4.2.5.tgz", - "integrity": "sha512-n6wvpdE43VFtJq+lUDYDBFUwV8TZbuGXLV4D6wKafg13ldznKsyEvatubnmUe31zcvelSzOHF+XbaT+Bl9ObDg==", - "dev": true - }, "escape-string-regexp": { "version": "1.0.5", "resolved": "https://registry.npmjs.org/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz", @@ -2756,12 +2753,6 @@ "integrity": "sha1-k0EP0hsAlzUVH4howvJx80J+I/0=", "dev": true }, - "home-path": { - "version": "1.0.6", - "resolved": "https://registry.npmjs.org/home-path/-/home-path-1.0.6.tgz", - "integrity": "sha512-wo+yjrdAtoXt43Vy92a+0IPCYViiyLAHyp0QVS4xL/tfvVz5sXIW1ubLZk3nhVkD92fQpUMKX+fzMjr5F489vw==", - "dev": true - }, "hosted-git-info": { "version": "2.6.0", "resolved": "https://registry.npmjs.org/hosted-git-info/-/hosted-git-info-2.6.0.tgz", diff --git a/package.json b/package.json index 623ead72..53451c50 100644 --- a/package.json +++ b/package.json @@ -173,7 +173,7 @@ "chai": "3.5.0", "crowdin": "1.0.0", "csvjson": "4.3.3", - "electron": "^2.0.14", + "electron": "^3.1.4", "electron-builder": "^20.28.3", "electron-packager": "^12.1.0", "mocha": "^5.2.0", From 086e5d2a776e809dc98b819700c070998bc635b5 Mon Sep 17 00:00:00 2001 From: mxb Date: Thu, 14 Mar 2019 17:23:46 +0100 Subject: [PATCH 4/5] Fix unread js for discord dm count --- app/store/ServicesList.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/store/ServicesList.js b/app/store/ServicesList.js index 134aa84c..eff20ee3 100644 --- a/app/store/ServicesList.js +++ b/app/store/ServicesList.js @@ -182,7 +182,7 @@ Ext.define('Rambox.store.ServicesList', { ,url: 'https://discordapp.com/login' ,type: 'messaging' ,titleBlink: true - ,js_unread: 'function getAlertCount(e){for(var t=0,a=0;ae+(r&&r.querySelector("[class*=avatar]")&&r.querySelector("[class*=wrapper][class*=badge]")?parseInt(r.querySelector("[class*=wrapper][class*=badge]").innerHTML):0),0);rambox.setUnreadCount(r)}setInterval(checkUnread,3e3);' ,note: 'To enable desktop notifications, you have to go to Options inside Discord. Will count only unread DMs.' ,userAgent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36' }, From 37381a0312f38eed69980d758d04cdb5c8b42ff8 Mon Sep 17 00:00:00 2001 From: Ramiro Saenz Date: Fri, 15 Mar 2019 03:50:30 -0300 Subject: [PATCH 5/5] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 53451c50..aedf6ef1 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "Rambox", "productName": "Rambox", - "version": "0.6.3", + "version": "0.6.4", "description": "Free and Open Source messaging and emailing app that combines common web applications into one.", "main": "electron/main.js", "repository": {