From c61ffb5f64c3d7f2c195e2a669e4d4ca212baac0 Mon Sep 17 00:00:00 2001 From: TheGoddessInari Date: Mon, 6 Aug 2018 10:44:41 -0700 Subject: [PATCH] Remove electron "browser plugin" support, as AFAICT, there's no use of it and none of the apps should be using plugins. If I'm wrong, let me know. Eg, I can call using Hangouts/GMail without it. Mobile webview support requires browser plugins to be disabled anyway. --- app/ux/WebView.js | 3 +-- electron/main.js | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/ux/WebView.js b/app/ux/WebView.js index 842f7356..172d1681 100644 --- a/app/ux/WebView.js +++ b/app/ux/WebView.js @@ -165,10 +165,9 @@ Ext.define('Rambox.ux.WebView',{ ,src: me.record.get('url') ,style: 'width:100%;height:100%;visibility:visible;' ,partition: 'persist:' + me.record.get('type') + '_' + me.id.replace('tab_', '') + (localStorage.getItem('id_token') ? '_' + Ext.decode(localStorage.getItem('profile')).user_id : '') - ,plugins: 'true' ,allowtransparency: 'on' ,autosize: 'on' - ,webpreferences: '' //,nativeWindowOpen=yes + ,webpreferences: '' //,nativeWindowOpen=true //,disablewebsecurity: 'on' // Disabled because some services (Like Google Drive) dont work with this enabled ,useragent: Ext.getStore('ServicesList').getById(me.record.get('type')).get('userAgent') ,preload: './resources/js/rambox-service-api.js' diff --git a/electron/main.js b/electron/main.js index a5d0c738..3124cdd9 100644 --- a/electron/main.js +++ b/electron/main.js @@ -87,8 +87,7 @@ function createWindow () { ,show: !config.get('start_minimized') ,acceptFirstMouse: true ,webPreferences: { - plugins: true - ,partition: 'persist:rambox' + partition: 'persist:rambox' } });