From ca7693bf843f71b6109bcb41d3360ef661fcface Mon Sep 17 00:00:00 2001
From: Ramiro Saenz <saenzramiro@gmail.com>
Date: Wed, 1 May 2019 21:35:55 -0300
Subject: [PATCH] Enable opening links in Skype

To make it work, user needs to disable Links Previews in Skype settings.

Fixes #711
---
 app/store/ServicesList.js | 2 +-
 app/ux/WebView.js         | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/store/ServicesList.js b/app/store/ServicesList.js
index bd00b692..4728bb50 100644
--- a/app/store/ServicesList.js
+++ b/app/store/ServicesList.js
@@ -72,7 +72,7 @@ Ext.define('Rambox.store.ServicesList', {
 			,description: locale['services[4]']
 			,url: 'https://web.skype.com/'
 			,type: 'messaging'
-			,note: 'Text and Audio calls are supported only. <a href="https://github.com/saenzramiro/rambox/wiki/Skype" target="_blank">Read more...</a>'
+			,note: 'Text and Audio calls are supported only. Be sure to disable Links Previews to make them work. <a href="https://github.com/ramboxapp/community-edition/wiki/Skype" target="_blank">Read more...</a>'
 		},
 		{
 			 id: 'hangouts'
diff --git a/app/ux/WebView.js b/app/ux/WebView.js
index dffbc0bd..82c7847f 100644
--- a/app/ux/WebView.js
+++ b/app/ux/WebView.js
@@ -315,9 +315,8 @@ Ext.define('Rambox.ux.WebView',{
 			switch ( me.type ) {
 				case 'skype':
 					// hack to fix multiple browser tabs on Skype link click, re #11
-					if ( e.url.match('https:\/\/web.skype.com\/..\/undefined') ) {
-						e.preventDefault();
-						return;
+					if ( require('url').parse(me.down('statusbar #url').html).protocol !== null ) {
+						e.url = me.down('statusbar #url').html;
 					} else if ( e.url.indexOf('imgpsh_fullsize') >= 0 ) {
 						ipc.send('image:download', e.url, e.target.partition);
 						e.preventDefault();