TheGoddessInari
3bad65cbe5
Fix IconLoader to properly set title. No more duplicate icons (rambox bug).
...
Fixes #225 again.
4 years ago
TheGoddessInari
b42bfb80ba
Stop escaping icons in the IconLoader. This is probably overkill anyway.
...
We only need to escape the user-supplied title possibly at worst.
Fixes #225
5 years ago
TheGoddessInari
2726c275c7
Fix Slack Icon after Redesign
...
Fixes #191 .
Co-authored-by: Marvin <marvin.koch@9elements.com>
5 years ago
TheGoddessInari
63ef9554dd
Escape title user inputs. Fix our version of CVE-2019-17625.
...
We take the simple/cheap way out and use ExtJS htmlEncode on all
entry points for this.
This is still mostly limited to 'doing it to yourself'.
The main fix is in app/view/main/Main.js where the title is rendered
out, and will apparently execute arbitrary javascript within a title
tag(!). This is an ExtJS thing, apparently, so we make it
unconditionally encode it to render on the bar.
Apparently this isn't the only place arbitrary execution can occur,
so just be safe(r).
5 years ago
TheGoddessInari
cc3398fc1f
Use string template literal for IconLoader.
6 years ago
TheGoddessInari
e2e6c2abe7
Fix Slack Icon Loading.
6 years ago
TheGoddessInari
cb24232b47
Rename baseline from Rambox-OS to Hamsket.
6 years ago
TheGoddessInari
97837a7e92
Replace var with let or const as appropriate.
6 years ago
TheGoddessInari
07201f2b15
Replace property functions with object/class method functions.
6 years ago
TheGoddessInari
798ee1efb8
Notifier: Remove open coding of tab activation.
6 years ago
TheGoddessInari
9b9ab1e8e1
Fix other linting errors. No lint makes for easier development.
7 years ago
_nderscore
bdaa608ceb
Fix slack service icon position when title empty.
...
Issue #1209
Use absolute positioning for slack service icon instead of margins to avoid incorrect positions without text content for service title.
8 years ago
Ramiro Saenz
09068be8c5
Improved IconLoader class
...
Related #1160
8 years ago
Maxime Myers
d80de2a610
Add tabs service icon loading (slack)
8 years ago
Ramiro Saenz
5682a9c91c
Fixed tray double click, show/hide window and notification click
...
Fixes #755
Fixes #700
Fixes #608
Fixes #235
8 years ago
Michael Weimann
6fe04d05fd
Removes debug logging
9 years ago
Michael Weimann
8d12b60858
Adds options to disable the unread count for a service per tab or globally
9 years ago
Ramiro Saenz
5e531499d8
Persistent Lock and improved usability for Locking flow
...
Fixes #128
9 years ago
Ramiro Saenz
8d8ef672e7
Fixed bug of app title related to badges
...
Related to #91
9 years ago
Ramiro Saenz
57220c5676
Badge bug fixed
...
Bug when badge in title is like (2.300)
Fixes #91
Fixes #92
9 years ago